[tor-commits] [tor/master] Use [ -n "$x" ] in place of [ ! -z "$x" ] in chutney-git-bisect

nickm at torproject.org nickm at torproject.org
Tue Jan 15 23:27:20 UTC 2019


commit 31e784915eaf90bf5794ff4f96989b9ff509ec8e
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Jan 15 18:26:08 2019 -0500

    Use [ -n "$x" ] in place of [ ! -z "$x" ] in chutney-git-bisect
    
    Closes 29099.
---
 scripts/test/chutney-git-bisect.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/test/chutney-git-bisect.sh b/scripts/test/chutney-git-bisect.sh
index dc1319a27..dcf8ab110 100755
--- a/scripts/test/chutney-git-bisect.sh
+++ b/scripts/test/chutney-git-bisect.sh
@@ -15,21 +15,21 @@
 # Skips the test if <skip-flavour> fails (default no skip).
 
 CHUTNEY_TRIES=3
-if [ ! -z "$1" ]; then
+if [ -n "$1" ]; then
     CHUTNEY_TRIES="$1"
 fi
 
-if [ ! -z "$2" ]; then
+if [ -n "$2" ]; then
     cd "$2" || exit
 fi
 
 CHUTNEY_TEST_CMD="make test-network-all"
-if [ ! -z "$3" ]; then
+if [ -n "$3" ]; then
     CHUTNEY_TEST_CMD="$CHUTNEY_PATH/tools/test-network.sh --flavour $3"
 fi
 
 CHUTNEY_SKIP_ON_FAIL_CMD="true"
-if [ ! -z "$4" ]; then
+if [ -n "$4" ]; then
     CHUTNEY_SKIP_ON_FAIL_CMD="$CHUTNEY_PATH/tools/test-network.sh --flavour $4"
 fi
 



More information about the tor-commits mailing list