[tor-commits] [tor/release-0.4.0] Downgrade some LOG_ERR messages in the address/* tests to warnings

arma at torproject.org arma at torproject.org
Wed Feb 20 15:40:02 UTC 2019


commit d32e4079761f0076cd9e704a7f9996aa5b599f60
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Feb 19 14:02:32 2019 -0500

    Downgrade some LOG_ERR messages in the address/* tests to warnings
    
    Fixes bug 29530, where the LOG_ERR messages were occurring when
    we had no configured network, and so we were failing the unit tests
    because of the recently-merged #28668.
    
    Bug not in any released Tor.
---
 src/test/test_address.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/test/test_address.c b/src/test/test_address.c
index d9304a0cf..bf9ca047d 100644
--- a/src/test/test_address.c
+++ b/src/test/test_address.c
@@ -746,7 +746,7 @@ test_address_get_if_addrs_list_internal(void *arg)
 
   (void)arg;
 
-  results = get_interface_address_list(LOG_ERR, 1);
+  results = get_interface_address_list(LOG_WARN, 1);
 
   tt_ptr_op(results, OP_NE, NULL);
   /* When the network is down, a system might not have any non-local
@@ -777,7 +777,7 @@ test_address_get_if_addrs_list_no_internal(void *arg)
 
   (void)arg;
 
-  results = get_interface_address_list(LOG_ERR, 0);
+  results = get_interface_address_list(LOG_WARN, 0);
 
   tt_ptr_op(results, OP_NE, NULL);
   /* Work even on systems with only internal IPv4 addresses */
@@ -988,7 +988,7 @@ test_address_get_if_addrs(void *arg)
 
   (void)arg;
 
-  rv = get_interface_address(LOG_ERR, &addr_h);
+  rv = get_interface_address(LOG_WARN, &addr_h);
 
   /* When the network is down, a system might not have any non-local
    * non-multicast IPv4 addresses, not even internal ones.





More information about the tor-commits mailing list