[tor-commits] [tor/master] hs-v3: Fix memory leak in test_hs_control_store_permanent_creds()

[dgoulet at torproject.org]

commit c959ea7558d059ebcf167d573b7a4327834982c7
Author: George Kadianakis <desnacked at riseup.net>
Date:   Wed Dec 4 13:40:03 2019 +0200

    hs-v3: Fix memory leak in test_hs_control_store_permanent_creds()
---
 src/test/test_hs_control.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/test/test_hs_control.c b/src/test/test_hs_control.c
index d064f203a..33ea9ada7 100644
--- a/src/test/test_hs_control.c
+++ b/src/test/test_hs_control.c
@@ -525,6 +525,7 @@ test_hs_control_store_permanent_creds(void *arg)
   { /* Setup ClientOnionAuthDir */
     int ret;
     char *perm_creds_dir = tor_strdup(get_fname("permanent_credentials"));
+    get_options_mutable()->ClientOnionAuthDir = perm_creds_dir;
 
     #ifdef _WIN32
       ret = mkdir(perm_creds_dir);
@@ -532,8 +533,6 @@ test_hs_control_store_permanent_creds(void *arg)
       ret = mkdir(perm_creds_dir, 0700);
     #endif
     tt_int_op(ret, OP_EQ, 0);
-
-    get_options_mutable()->ClientOnionAuthDir = perm_creds_dir;
   }
 
   tor_free(args);
@@ -622,6 +621,7 @@ test_hs_control_store_permanent_creds(void *arg)
   tt_uint_op(digest256map_size(client_auths), OP_EQ, 0);
 
  done:
+  tor_free(get_options_mutable()->ClientOnionAuthDir);
   tor_free(args);
   tor_free(cp1);
   buf_free(TO_CONN(&conn)->outbuf);