[tor-commits] [tor/master] control: Remove an unused function return value

teor at torproject.org teor at torproject.org
Sun Dec 1 07:54:29 UTC 2019


commit f8f278f8c43358d5eb1d316008375313ddbe0fee
Author: teor <teor at torproject.org>
Date:   Fri Nov 29 10:54:42 2019 +1000

    control: Remove an unused function return value
    
    Cleanup after 31531.
---
 src/feature/control/control_events.c | 5 ++---
 src/feature/control/control_events.h | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/feature/control/control_events.c b/src/feature/control/control_events.c
index fb3410b89..82349bc6a 100644
--- a/src/feature/control/control_events.c
+++ b/src/feature/control/control_events.c
@@ -1774,13 +1774,13 @@ control_event_guard(const char *nickname, const char *digest,
  * by SETCONF requests and RELOAD/SIGHUP signals. The <b>changes</b> are
  * a smartlist_t containing (key, value, ...) pairs in sequence.
  * <b>changes</b> can be NULL. */
-int
+void
 control_event_conf_changed(const config_line_t *changes)
 {
   char *result;
   smartlist_t *lines;
   if (!EVENT_IS_INTERESTING(EVENT_CONF_CHANGED) || !changes) {
-    return 0;
+    return;
   }
   lines = smartlist_new();
   for (const config_line_t *line = changes; line; line = line->next) {
@@ -1796,7 +1796,6 @@ control_event_conf_changed(const config_line_t *changes)
   tor_free(result);
   SMARTLIST_FOREACH(lines, char *, cp, tor_free(cp));
   smartlist_free(lines);
-  return 0;
 }
 
 /** We just generated a new summary of which countries we've seen clients
diff --git a/src/feature/control/control_events.h b/src/feature/control/control_events.h
index 833727a49..edb0e90cd 100644
--- a/src/feature/control/control_events.h
+++ b/src/feature/control/control_events.h
@@ -158,7 +158,7 @@ int control_event_server_error(const char *format, ...)
 
 int control_event_guard(const char *nickname, const char *digest,
                         const char *status);
-int control_event_conf_changed(const struct config_line_t *changes);
+void control_event_conf_changed(const struct config_line_t *changes);
 int control_event_buildtimeout_set(buildtimeout_set_event_t type,
                                    const char *args);
 int control_event_signal(uintptr_t signal);





More information about the tor-commits mailing list