[tor-commits] [tor/release-0.4.0] Actually I believe this should be an EINVAL.

nickm at torproject.org nickm at torproject.org
Tue Apr 9 17:52:02 UTC 2019


commit 9f3f99938e441c09c1b3bf64510b8fb682dba007
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Apr 9 13:49:10 2019 -0400

    Actually I believe this should be an EINVAL.
---
 src/test/test_util.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/test/test_util.c b/src/test/test_util.c
index 1b8897a17..3a0eb1515 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -699,13 +699,6 @@ test_util_time(void *arg)
 
 #define CHECK_TIMEGM_ARG_OUT_OF_RANGE(msg) \
     CHECK_TIMEGM_WARNING("Out-of-range argument to tor_timegm")
-#define CHECK_POSSIBLE_TIMEGM_ARG_OUT_OF_RANGE(msg)             \
-  do {                                                          \
-    if (mock_saved_log_n_entries()) {                           \
-      expect_single_log_msg_containing("Out-of-range argument");\
-    }                                                           \
-    teardown_capture_of_logs();                                 \
-  } while (0)
 
   /* year */
 
@@ -894,7 +887,7 @@ test_util_time(void *arg)
   t_res = -1;
   CAPTURE();
   tor_gmtime_r(&t_res, &b_time);
-  CHECK_POSSIBLE_TIMEGM_ARG_OUT_OF_RANGE();
+  CHECK_POSSIBLE_EINVAL();
   tt_assert(b_time.tm_year == (1970-1900) ||
             b_time.tm_year == (1969-1900));
 





More information about the tor-commits mailing list