[tor-commits] [tor/master] Fix SC2086 warnings in asciidoc-helper.sh

[teor at torproject.org]

commit 283ee0ba0a1540a9e8e8d68625d89315a5356162
Author: rl1987 <rl1987 at sdf.lonestar.org>
Date:   Wed Mar 27 19:27:57 2019 +0200

    Fix SC2086 warnings in asciidoc-helper.sh
---
 changes/bug29926       | 2 ++
 doc/asciidoc-helper.sh | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/changes/bug29926 b/changes/bug29926
new file mode 100644
index 000000000..ab1417c60
--- /dev/null
+++ b/changes/bug29926
@@ -0,0 +1,2 @@
+  o Code simplification and refactoring (shell scripts):
+    - Fix shellcheck warnings in asciidoc-helper.sh. Resolves issue 29926.
diff --git a/doc/asciidoc-helper.sh b/doc/asciidoc-helper.sh
index a3ef53f88..765850a12 100755
--- a/doc/asciidoc-helper.sh
+++ b/doc/asciidoc-helper.sh
@@ -19,7 +19,7 @@ if [ "$1" = "html" ]; then
     base=${output%%.html.in}
 
     if [ "$2" != none ]; then
-      TZ=UTC "$2" -d manpage -o $output $input;
+      TZ=UTC "$2" -d manpage -o "$output" "$input";
     else
       echo "==================================";
       echo;
@@ -44,8 +44,8 @@ elif [ "$1" = "man" ]; then
       echo "==================================";
       exit 1;
     fi
-    if "$2" -f manpage $input; then
-      mv $base.1 $output;
+    if "$2" -f manpage "$input"; then
+      mv "$base.1" "$output";
     else
       cat<<EOF
 ==================================