[tor-commits] [tor/master] Fix an NSS socket leak-on-error found by dgoulet

nickm at torproject.org nickm at torproject.org
Thu Sep 20 18:09:57 UTC 2018


commit 4e2028152d31e27c44d0c2ef31dca829c6ae2d2e
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Sep 20 13:53:04 2018 -0400

    Fix an NSS socket leak-on-error found by dgoulet
---
 src/lib/tls/tortls_nss.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/tls/tortls_nss.c b/src/lib/tls/tortls_nss.c
index e1e6cc501..462cd5b0f 100644
--- a/src/lib/tls/tortls_nss.c
+++ b/src/lib/tls/tortls_nss.c
@@ -452,6 +452,7 @@ tor_tls_release_socket(tor_tls_t *tls)
 
   PRFileDesc *tcp = PR_GetIdentitiesLayer(tls->ssl, PR_NSPR_IO_LAYER);
   if (BUG(! tcp)) {
+    tor_close_socket(sock);
     return;
   }
 



More information about the tor-commits mailing list