[tor-commits] [tor/master] Fix a memory leak in tortls/openssl/try_to_extract_certs_from_tls

[nickm at torproject.org]

commit 15596f6c0c0a8aea262c225ebb99ce0caeecc562
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Sep 13 12:47:42 2018 -0400

    Fix a memory leak in tortls/openssl/try_to_extract_certs_from_tls
    
    Since this is an "intrusive" test, it only shows up for openssl <1.1
    
    This is a bugfix on 0.3.5.x; bug not in any released Tor.
---
 src/test/test_tortls_openssl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/test/test_tortls_openssl.c b/src/test/test_tortls_openssl.c
index 608625288..3928b754a 100644
--- a/src/test/test_tortls_openssl.c
+++ b/src/test/test_tortls_openssl.c
@@ -1007,6 +1007,7 @@ test_tortls_try_to_extract_certs_from_tls(void *ignored)
   tt_assert(cert == c1);
   tt_assert(id_cert);
   X509_free(cert); /* decrease refcnt */
+  X509_free(id_cert); /* decrease refcnt */
 
  done:
   sk_X509_free(sess->cert_chain);