[tor-commits] [tor/release-0.3.3] Treat backtrace test failures as expected on most BSD-derived systems

nickm at torproject.org nickm at torproject.org
Wed Oct 31 15:01:46 UTC 2018


commit 939657771c7d2832fcedf51c0b250841d907e07f
Author: teor <teor at torproject.org>
Date:   Tue Oct 23 11:21:10 2018 +1000

    Treat backtrace test failures as expected on most BSD-derived systems
    
    Treat backtrace test failures as expected on NetBSD, OpenBSD, and
    macOS/Darwin, until we solve bug 17808.
    
    (FreeBSD failures have been treated as expected since 18204 in 0.2.8.)
    
    Fixes bug 27948; bugfix on 0.2.5.2-alpha.
---
 changes/bug27948    |  6 ++++++
 src/test/bt_test.py | 10 ++++++----
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/changes/bug27948 b/changes/bug27948
new file mode 100644
index 000000000..fea16f3d0
--- /dev/null
+++ b/changes/bug27948
@@ -0,0 +1,6 @@
+  o Minor bugfixes (tests):
+    - Treat backtrace test failures as expected on BSD-derived systems
+      (NetBSD, OpenBSD, and macOS/Darwin) until we solve bug 17808.
+      (FreeBSD failures have been treated as expected since 18204 in 0.2.8.)
+      Fixes bug 27948; bugfix on 0.2.5.2-alpha.
+
diff --git a/src/test/bt_test.py b/src/test/bt_test.py
index 30591453b..a1efca00f 100755
--- a/src/test/bt_test.py
+++ b/src/test/bt_test.py
@@ -44,10 +44,12 @@ print("BAD")
 for l in LINES:
     print("{}".format(l), end="")
 
-if sys.platform.startswith('freebsd'):
-    # See bug #17808 if you know how to fix this.
-    print("Test failed; but FreeBSD is known to have backtrace problems.\n"
-          "Treating as 'SKIP'.")
+if (sys.platform.startswith('freebsd') or sys.platform.startswith('netbsd') or
+    sys.platform.startswith('openbsd') or sys.platform.startswith('darwin')):
+    # See bug #17808 if you know how to fix backtraces on BSD-derived systems
+    print("Test failed; but {} is known to have backtrace problems."
+          .format(sys.platform))
+    print("Treating as 'SKIP'.")
     sys.exit(77)
 
 sys.exit(1)





More information about the tor-commits mailing list