[tor-commits] [tor/master] Fix a misspelled macro test that was breaking big-endian OPE

nickm at torproject.org nickm at torproject.org
Wed Oct 24 14:20:57 UTC 2018


commit f8a1dc64f975bcaa74634f4666e448ca3fe88d3b
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Oct 19 08:41:25 2018 -0400

    Fix a misspelled macro test that was breaking big-endian OPE
    
    Fixes bug 28115; bugfix on 0.3.5.1-alpha.
---
 changes/bug28115               | 3 +++
 src/lib/crypt_ops/crypto_ope.c | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/changes/bug28115 b/changes/bug28115
new file mode 100644
index 000000000..e3e29968e
--- /dev/null
+++ b/changes/bug28115
@@ -0,0 +1,3 @@
+  o Minor bugfixes (portability):
+    - Make the OPE code (which is used for v3 onion services) run correctly
+      on big-endian platforms. Fixes bug 28115; bugfix on 0.3.5.1-alpha.
diff --git a/src/lib/crypt_ops/crypto_ope.c b/src/lib/crypt_ops/crypto_ope.c
index fd5d5f377..47e246127 100644
--- a/src/lib/crypt_ops/crypto_ope.c
+++ b/src/lib/crypt_ops/crypto_ope.c
@@ -48,7 +48,7 @@ struct crypto_ope_t {
 /** The type to add up in order to produce our OPE ciphertexts */
 typedef uint16_t ope_val_t;
 
-#ifdef WORDS_BIG_ENDIAN
+#ifdef WORDS_BIGENDIAN
 /** Convert an OPE value to little-endian */
 static inline ope_val_t
 ope_val_to_le(ope_val_t x)





More information about the tor-commits mailing list