[tor-commits] [tor/master] Prevent duplicate initialization of NSS DH module

nickm at torproject.org nickm at torproject.org
Tue Oct 9 13:05:09 UTC 2018


commit 9e1a3be0645ca2dad7d6eb8aa00559efec945835
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Sep 27 13:26:47 2018 -0400

    Prevent duplicate initialization of NSS DH module
    
    Allowing this didn't do any actual harm, since there aren't any
    shared structures or leakable objects here.  Still, it's bad style
    and might cause trouble in the future.
    
    Closes ticket 27856.
---
 src/lib/crypt_ops/crypto_dh_nss.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/crypt_ops/crypto_dh_nss.c b/src/lib/crypt_ops/crypto_dh_nss.c
index 9a14b809b..e2d9040f5 100644
--- a/src/lib/crypt_ops/crypto_dh_nss.c
+++ b/src/lib/crypt_ops/crypto_dh_nss.c
@@ -53,6 +53,8 @@ crypto_dh_init_nss(void)
   circuit_dh_param.prime.len = DH1024_KEY_LEN;
   circuit_dh_param.base.data = dh_generator_data;
   circuit_dh_param.base.len = 1;
+
+  dh_initialized = 1;
 }
 
 void





More information about the tor-commits mailing list