[tor-commits] [tor/release-0.3.4] Fix a bug in usage of SSL_set1_groups_list()

nickm at torproject.org nickm at torproject.org
Sun Nov 11 23:05:59 UTC 2018


commit 46796623f995c5b63d5cfbda1a038d9f6158ec90
Author: Nick Mathewson <nickm at torproject.org>
Date:   Sun Nov 11 18:03:50 2018 -0500

    Fix a bug in usage of SSL_set1_groups_list()
    
    Apparently, even though the manpage says it returns an int, it
    can return a long instead and cause a warning.
    
    Bug not in any released Tor.  Part of #28399
---
 src/common/tortls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/common/tortls.c b/src/common/tortls.c
index 7c50f8711..1fbe3c663 100644
--- a/src/common/tortls.c
+++ b/src/common/tortls.c
@@ -1228,7 +1228,7 @@ tor_tls_context_new(crypto_pk_t *identity, unsigned int key_lifetime,
       list = "P-256:P-224";
     else
       list = "P-256:P-224";
-    int r = SSL_CTX_set1_groups_list(result->ctx, list);
+    int r = (int) SSL_CTX_set1_groups_list(result->ctx, list);
     if (r < 0)
       goto error;
   }





More information about the tor-commits mailing list