[tor-commits] [tor-browser-build/master] Bug 26054: Make sure to create incrementals from previously signed MAR files

gk at torproject.org gk at torproject.org
Wed May 23 12:38:02 UTC 2018


commit 0bfae091fa18b6bca05de2cac42bacac47381876
Author: Nicolas Vigier <boklm at torproject.org>
Date:   Mon May 21 15:54:31 2018 +0200

    Bug 26054: Make sure to create incrementals from previously signed MAR files
---
 tools/update-responses/update_responses | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/update-responses/update_responses b/tools/update-responses/update_responses
index bf2415d..1df35b3 100755
--- a/tools/update-responses/update_responses
+++ b/tools/update-responses/update_responses
@@ -209,6 +209,10 @@ sub create_incremental_mar {
     my $tmpdir = get_tmpdir($config);
     extract_mar(mar_filename($config, $appname, $from_version, $os, $lang), "$tmpdir/A");
     extract_mar(mar_filename($config, $appname, $new_version, $os, $lang), "$tmpdir/B");
+    # bug 26054: make sure previous macOS version is code signed
+    if (($os eq 'osx64') && ! -f "$tmpdir/A/Contents/_CodeSignature/CodeResources") {
+        exit_error "Missing code signature in $from_version while creating $mar_file";
+    }
     if ($ENV{CHECK_CODESIGNATURE_EXISTS}) {
         unless (-f "$tmpdir/A/Contents/_CodeSignature/CodeResources"
             && -f "$tmpdir/B/Contents/_CodeSignature/CodeResources") {



More information about the tor-commits mailing list