[tor-commits] [orbot/master] removed legacy READ_PHONE_STATE perm

[n8fr8 at torproject.org]

commit 505223b3a1894588de0802669b3269a89edeb4b1
Author: lexi <bird.s.lex at gmail.com>
Date:   Thu Apr 12 13:29:22 2018 -0400

    removed legacy READ_PHONE_STATE perm
---
 app/src/fullperm/AndroidManifest.xml | 1 -
 docs/WALKTHROUGH                     | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/app/src/fullperm/AndroidManifest.xml b/app/src/fullperm/AndroidManifest.xml
index c3c5f8f6..d2497e4c 100644
--- a/app/src/fullperm/AndroidManifest.xml
+++ b/app/src/fullperm/AndroidManifest.xml
@@ -14,7 +14,6 @@
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" />
-    <uses-permission android:name="android.permission.READ_PHONE_STATE" />
     <!-- Some Chromebooks don't support touch. Although not essential,
          it's a good idea to explicitly include this declaration. -->
     <uses-feature android:name="android.hardware.touchscreen"
diff --git a/docs/WALKTHROUGH b/docs/WALKTHROUGH
index 184a7d29..55a356b5 100644
--- a/docs/WALKTHROUGH
+++ b/docs/WALKTHROUGH
@@ -20,11 +20,6 @@
                         //this is the class registered in AndroidManifest.xml to handle Onboot events
                         //to start Orbot/Tor when the device boots if the user has elected to do so - what kind of permissions does this require?
                         //                 <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>
-                        // BTW, this shows up as a fairly unintrusive type perm request now in Android / in older versions (1.6 and earlier)
-                        // it was reported "as read / monitor phone state" and paranoid Tor-types didn't like the idea of it
-                        // in 1.6+ it has a much better UX in terms of having a more granular permisions around boot since it is a very
-                        // common request - ah , that's awesome, i think i remember seeing sth of this sorts when i was going through the guardianproject mailing list. iirc this is something ioerror wanted
-                        
             
             ├── OrbotMainActivity.java
                     //our wonderful main activity!