[tor-commits] [tor-browser/tor-browser-52.7.2esr-8.0-1] Orfox: remove Tab:Load event queuing and only use Intent queuing

gk at torproject.org gk at torproject.org
Tue Mar 20 11:26:34 UTC 2018


commit 274ae1ec2dcacb68e860f7aa1d10a10504877507
Author: Hans-Christoph Steiner <hans at eds.org>
Date:   Fri Sep 18 11:03:18 2015 +0200

    Orfox: remove Tab:Load event queuing and only use Intent queuing
    
    Tab:Load queuing is too flaky, since the Fennec UI will block waiting for
    Gecko to confirm that it received the event.  For more on this:
    
    refs #5530 https://dev.guardianproject.info/issues/5530
    https://lists.mayfirst.org/pipermail/guardian-dev/2015-September/004499.html
    
    Signed-off-by: Amogh Pradeep <amoghbl1 at gmail.com>
---
 mobile/android/base/java/org/mozilla/gecko/BrowserApp.java | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
index 34f93ee56cdb..8cb69ce011ab 100644
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -1080,12 +1080,7 @@ public class BrowserApp extends GeckoApp
         @Override
         public void onReceive(Context context, Intent intent) {
             if (TextUtils.equals(intent.getAction(), OrbotHelper.ACTION_STATUS)) {
-                String status = intent.getStringExtra(OrbotHelper.EXTRA_STATUS);
-                Tabs.getInstance().setTorStatus(status);
-
-                if (status.equals(OrbotHelper.STATUS_ON)) {
-                    GeckoAppShell.sendPendingUrlIntents(BrowserApp.this);
-                }
+                GeckoAppShell.setTorStatus(intent);
             }
         }
     };





More information about the tor-commits mailing list