[tor-commits] [tor/release-0.3.3] Fix memory leak in disk_state_parse_commits().

nickm at torproject.org nickm at torproject.org
Fri Jun 29 17:06:30 UTC 2018

commit 3395de51a01aa5519c52404ed2bb9c8cda3571c9
Author: Alexander Færøy <ahf at torproject.org>
Date:   Sat Jun 23 11:28:00 2018 +0200

    Fix memory leak in disk_state_parse_commits().
    This patch fixes a memory leak in disk_state_parse_commits() where if
    commit is NULL, we continue the internal loop, but without ever freeing
    the args variable.
    See: Coverity CID 1437441.
 src/or/shared_random_state.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/or/shared_random_state.c b/src/or/shared_random_state.c
index 87db9031e..8438d4640 100644
--- a/src/or/shared_random_state.c
+++ b/src/or/shared_random_state.c
@@ -409,6 +409,7 @@ disk_state_parse_commits(sr_state_t *state,
     if (commit == NULL) {
       /* Ignore badly formed commit. It could also be a authority
        * fingerprint that we don't know about so it shouldn't be used. */
+      smartlist_free(args);
     /* We consider parseable commit from our disk state to be valid because

More information about the tor-commits mailing list