[tor-commits] [tor/master] Increase OPE_INPUT_MAX.

nickm at torproject.org nickm at torproject.org
Tue Jul 17 20:19:40 UTC 2018


commit 34a5eb5904896cfbfb8c2729fe3b029fab6deb39
Author: George Kadianakis <desnacked at riseup.net>
Date:   Thu Jun 14 15:23:09 2018 +0300

    Increase OPE_INPUT_MAX.
---
 src/lib/crypt_ops/crypto_ope.h | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/lib/crypt_ops/crypto_ope.h b/src/lib/crypt_ops/crypto_ope.h
index 885ce84b2..823524f84 100644
--- a/src/lib/crypt_ops/crypto_ope.h
+++ b/src/lib/crypt_ops/crypto_ope.h
@@ -13,8 +13,18 @@
 /** Length of OPE key, in bytes. */
 #define OPE_KEY_LEN 32
 
-/** Largest value that can be passed to crypto_ope_encrypt() */
-#define OPE_INPUT_MAX 131072
+/** Largest value that can be passed to crypto_ope_encrypt().
+ *
+ *  Expressed as 2^18 because the OPE system prefers powers of two.
+ *
+ *  The current max value stands for about 70 hours. The rationale here is as
+ *  follows: The rev counter is the time of seconds since the start of an SRV
+ *  period. SRVs are useful for about 48 hours (that's how long they stick
+ *  around on the consensus). Let's also add 12 hours of drift for clock skewed
+ *  services that might be using an old consensus and we arrive to 60
+ *  hours. The max value should be beyond that.
+ */
+#define OPE_INPUT_MAX (1<<18)
 
 typedef struct crypto_ope_c crypto_ope_t;
 





More information about the tor-commits mailing list