[tor-commits] [doctor/master] Don't alert about the Running flag count

[atagar at torproject.org]

commit db22d866124cf49a7c39311e5a6d1c8264c69def
Author: Damian Johnson <atagar at torproject.org>
Date:   Sat Feb 17 13:14:15 2018 -0800

    Don't alert about the Running flag count
    
    When an authority first starts up it doesn't vote on the Running flag. Smarter
    thing would be to check the known-flags in the vote to see if Running is there,
    but for now just dropping the false alarms...
    
      https://lists.torproject.org/pipermail/tor-consensus-health/2018-February/008580.html
---
 consensus_health_checker.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/consensus_health_checker.py b/consensus_health_checker.py
index a4a84e6..72f50f9 100755
--- a/consensus_health_checker.py
+++ b/consensus_health_checker.py
@@ -636,7 +636,13 @@ def has_similar_flag_counts(latest_consensus, consensuses, votes):
         authority_flag_count[flag] = authority_flag_count.setdefault(flag, 0) + 1
 
     for flag, count in flag_count.items():
-      if flag == 'BadExit' or flag == 'HSDir':
+      # Skipping check for the following flags because...
+      #
+      #   * BadExit is only voted on by a few authorities.
+      #   * Running isn't voted on when an authority first starts up.
+      #   * moria1 likes to experiment with the HSDir flag.
+
+      if flag in ('BadExit', 'Running', 'HSDir'):
         continue
 
       vote_count = authority_flag_count.get(flag, 0)