[tor-commits] [tor/maint-0.2.9] Stop calculating total twice in frac_nodes_with_descriptors()

[nickm at torproject.org]

commit 6e4ebd41bb5479ffe05ed173a1d7aeffcf592248
Author: teor <teor2345 at gmail.com>
Date:   Wed Nov 8 14:18:46 2017 +1100

    Stop calculating total twice in frac_nodes_with_descriptors()
    
    Cleanup after 23318.
---
 src/or/routerlist.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/or/routerlist.c b/src/or/routerlist.c
index c9d2cbaea..8f53c0200 100644
--- a/src/or/routerlist.c
+++ b/src/or/routerlist.c
@@ -2768,12 +2768,10 @@ frac_nodes_with_descriptors(const smartlist_t *sl,
     return ((double)n_with_descs) / (double)smartlist_len(sl);
   }
 
-  total = present = 0.0;
+  present = 0.0;
   SMARTLIST_FOREACH_BEGIN(sl, const node_t *, node) {
-    const double bw = bandwidths[node_sl_idx];
-    total += bw;
     if (node_has_descriptor(node))
-      present += bw;
+      present += bandwidths[node_sl_idx];
   } SMARTLIST_FOREACH_END(node);
 
   tor_free(bandwidths);