[tor-commits] [tor/master] Refrain from closing connection if found one unrecognized address in NETINFO cell

nickm at torproject.org nickm at torproject.org
Thu Dec 20 13:02:26 UTC 2018


commit 5b2acbec0e50a1858c43d0cafe9c4696152cde27
Author: rl1987 <rl1987 at sdf.lonestar.org>
Date:   Sun Dec 16 10:19:37 2018 +0200

    Refrain from closing connection if found one unrecognized address in NETINFO cell
---
 src/core/or/channeltls.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/core/or/channeltls.c b/src/core/or/channeltls.c
index 392e78506..8f407d5e1 100644
--- a/src/core/or/channeltls.c
+++ b/src/core/or/channeltls.c
@@ -1809,10 +1809,8 @@ channel_tls_process_netinfo_cell(cell_t *cell, channel_tls_t *chan)
 
     if (tor_addr_from_netinfo_addr(&addr, netinfo_addr) == -1) {
       log_fn(LOG_PROTOCOL_WARN,  LD_OR,
-             "Bad address in netinfo cell; closing connection.");
-      connection_or_close_for_error(chan->conn, 0);
-      netinfo_cell_free(netinfo_cell);
-      return;
+             "Bad address in netinfo cell; Skipping.");
+      continue;
     }
     /* A relay can connect from anywhere and be canonical, so
      * long as it tells you from where it came. This may sound a bit





More information about the tor-commits mailing list