[tor-commits] [tor/master] Make the topological-sort output off by default

nickm at torproject.org nickm at torproject.org
Wed Dec 5 13:19:33 UTC 2018


commit fae29f7b424460353b3a5ab44e1394fdc28cc4c4
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Nov 7 10:59:23 2018 -0500

    Make the topological-sort output off by default
---
 scripts/maint/checkIncludes.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/maint/checkIncludes.py b/scripts/maint/checkIncludes.py
index ecda3fc56..3afd9bbeb 100755
--- a/scripts/maint/checkIncludes.py
+++ b/scripts/maint/checkIncludes.py
@@ -135,6 +135,7 @@ def load_include_rules(fname):
     return result
 
 list_unused = False
+log_sorted_levels = False
 
 uses_dirs = { }
 
@@ -169,11 +170,12 @@ while uses_dirs:
     for k in cur_level:
         del uses_dirs[k]
     n += 1
-    if cur_level:
+    if cur_level and log_sorted_levels:
         print(n, cur_level)
     if n > 100:
         break
 
 if uses_dirs:
-    print("Circular dependencies in here somewhere:", uses_dirs)
+    print("There are circular .may_include dependencies in here somewhere:",
+          uses_dirs)
     sys.exit(1)





More information about the tor-commits mailing list