[tor-commits] [snowflake/master] Remove duplicate ProxyPair tests from util.spec.coffee.

[dcf at torproject.org]

commit 261ef8f5bc26a35219bb1206968843d8e53b4254
Author: David Fifield <david at bamsoftware.com>
Date:   Tue Dec 4 13:37:51 2018 -0700

    Remove duplicate ProxyPair tests from util.spec.coffee.
---
 proxy/spec/util.spec.coffee | 81 ---------------------------------------------
 1 file changed, 81 deletions(-)

diff --git a/proxy/spec/util.spec.coffee b/proxy/spec/util.spec.coffee
index 1d99b04..fd5b77e 100644
--- a/proxy/spec/util.spec.coffee
+++ b/proxy/spec/util.spec.coffee
@@ -265,84 +265,3 @@ describe 'Params', ->
         .toEqual DEFAULT
       expect getAddress { addr: '---' }
         .toBeNull()
-
-describe 'ProxyPair', ->
-  fakeRelay = Parse.address '0.0.0.0:12345'
-  rateLimit = new DummyRateLimit()
-  destination = []
-  # Fake snowflake to interact with
-  snowflake = {
-    broker:
-      sendAnswer: ->
-  }
-  pp = new ProxyPair(fakeRelay, rateLimit)
-
-  it 'begins webrtc connection', ->
-    pp.begin()
-    expect(pp.pc).not.toBeNull()
-
-  it 'accepts WebRTC offer from some client', ->
-    it 'rejects invalid offers', ->
-      expect(pp.receiveWebRTCOffer {}).toBe false
-      expect pp.receiveWebRTCOffer {
-        type: 'answer'
-      }.toBeFalse()
-    it 'accepts valid offers', ->
-      goodOffer = {
-        type: 'offer'
-        sdp: 'foo'
-      }
-      expect(pp.receiveWebRTCOffer goodOffer).toBe true
-
-  it 'responds with a WebRTC answer correctly', ->
-    spyOn snowflake.broker, 'sendAnswer'
-    pp.pc.onicecandidate {
-      candidate: null
-    }
-    expect(snowflake.broker.sendAnswer).toHaveBeenCalled()
-
-  it 'handles a new data channel correctly', ->
-    expect(pp.client).toBeNull()
-    pp.pc.ondatachannel {
-      channel: {}
-    }
-    expect(pp.client).not.toBeNull()
-    expect(pp.client.onopen).not.toBeNull()
-    expect(pp.client.onclose).not.toBeNull()
-    expect(pp.client.onerror).not.toBeNull()
-    expect(pp.client.onmessage).not.toBeNull()
-
-  it 'connects to the relay once datachannel opens', ->
-    spyOn pp, 'connectRelay'
-    pp.client.onopen()
-    expect(pp.connectRelay).toHaveBeenCalled()
-
-  it 'connects to a relay', ->
-    pp.connectRelay()
-    expect(pp.relay.onopen).not.toBeNull()
-    expect(pp.relay.onclose).not.toBeNull()
-    expect(pp.relay.onerror).not.toBeNull()
-    expect(pp.relay.onmessage).not.toBeNull()
-
-  it 'flushes data between client and relay', ->
-
-    it 'proxies data from client to relay', ->
-      spyOn pp.relay, 'send'
-      pp.c2rSchedule.push { data: 'foo' }
-      pp.flush()
-      expect(pp.client.send).not.toHaveBeenCalled()
-      expect(pp.relay.send).toHaveBeenCalledWith 'foo'
-
-    it 'proxies data from relay to client', ->
-      spyOn pp.client, 'send'
-      pp.r2cSchedule.push { data: 'bar' }
-      pp.flush()
-      expect(pp.client.send).toHaveBeenCalledWith 'bar'
-      expect(pp.relay.send).not.toHaveBeenCalled()
-
-    it 'sends nothing with nothing to flush', ->
-      pp.flush()
-      expect(pp.client.send).not.toHaveBeenCalled()
-      expect(pp.relay.send).not.toHaveBeenCalled()
-
-  # TODO: rate limit tests