[tor-commits] [sbws/master] Make two tests actually test something

pastly at torproject.org pastly at torproject.org
Thu Aug 9 14:21:19 UTC 2018


commit 6008858afa1ebdfd803ecb4c316dfbdaa2edc8b2
Author: Matt Traudt <sirmatt at ksu.edu>
Date:   Mon Jul 23 13:30:55 2018 -0400

    Make two tests actually test something
---
 tests/unit/util/test_state.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/unit/util/test_state.py b/tests/unit/util/test_state.py
index 5e140fe..dd23d1a 100644
--- a/tests/unit/util/test_state.py
+++ b/tests/unit/util/test_state.py
@@ -68,7 +68,7 @@ def test_state_del(tmpdir):
     attempt_keys = (15983, None, True, -1.2, [], {}, set())
     for key in attempt_keys:
         try:
-            del state[False]
+            del state[key]
         except TypeError:
             pass
         else:
@@ -116,5 +116,4 @@ def test_state_iter(tmpdir):
     d = {'a': 1, 'b': 2, 'c': 3, 'd': 4}
     for key in d:
         state[key] = d[key]
-    for key in state:
-        pass
+    assert set([key for key in state]) == set(d)





More information about the tor-commits mailing list