[tor-commits] [tor/maint-0.3.3] Fix a copy-paste error in the fix for #23693.

nickm at torproject.org nickm at torproject.org
Wed Apr 25 12:02:18 UTC 2018


commit bb35405d2ad01dbc8cf59ed275c41bd7d6098ae8
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Apr 25 08:00:55 2018 -0400

    Fix a copy-paste error in the fix for #23693.
    
    Found by coverity; CID 25912; bug not in any released Tor.
---
 src/or/router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/or/router.c b/src/or/router.c
index f29ebbdf8..5405d3126 100644
--- a/src/or/router.c
+++ b/src/or/router.c
@@ -143,7 +143,7 @@ dup_onion_keys(crypto_pk_t **key, crypto_pk_t **last)
   if (onionkey)
     *key = crypto_pk_copy_full(onionkey);
   else
-    *last = NULL;
+    *key = NULL;
   if (lastonionkey)
     *last = crypto_pk_copy_full(lastonionkey);
   else





More information about the tor-commits mailing list