[tor-commits] [tor/master] Remove a duplicate call to update_microdesc_downloads()

nickm at torproject.org nickm at torproject.org
Thu Oct 26 13:11:25 UTC 2017


commit dfd3ed5bdc252ad2c3afed922e5dcd955eff1d68
Author: George Kadianakis <desnacked at riseup.net>
Date:   Wed Oct 25 19:18:38 2017 +0300

    Remove a duplicate call to update_microdesc_downloads()
    
    This call happens before we update our entry guards, so it needs to be
    removed for the fix to #23862 to work.
---
 src/or/directory.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/or/directory.c b/src/or/directory.c
index 272b324db..777972d57 100644
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -2667,11 +2667,11 @@ handle_response_fetch_consensus(dir_connection_t *conn,
   /* If we launched other fetches for this consensus, cancel them. */
   connection_dir_close_consensus_fetches(conn, flavname);
 
-  /* launches router downloads as needed */
+  /* update the list of routers and directory guards */
   routers_update_all_from_networkstatus(now, 3);
   update_microdescs_from_networkstatus(now);
-  update_microdesc_downloads(now);
   directory_info_has_arrived(now, 0, 0);
+
   if (authdir_mode_v3(get_options())) {
     sr_act_post_consensus(
                      networkstatus_get_latest_consensus_by_flavor(FLAV_NS));





More information about the tor-commits mailing list