[tor-commits] [stem/master] Unit test consensus' validate_signatures()

[atagar at torproject.org]

commit 2f922358f6ad428c30d536dee7634c7e1f4ad637
Author: Damian Johnson <atagar at torproject.org>
Date:   Thu May 25 10:50:15 2017 -0700

    Unit test consensus' validate_signatures()
    
    Sweet! Thanks to teor we have a validly signed test consensus so can now add a
    unit test for signature validation.
---
 test/unit/descriptor/networkstatus/document_v3.py | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/test/unit/descriptor/networkstatus/document_v3.py b/test/unit/descriptor/networkstatus/document_v3.py
index 76017fa..efdf1bb 100644
--- a/test/unit/descriptor/networkstatus/document_v3.py
+++ b/test/unit/descriptor/networkstatus/document_v3.py
@@ -9,6 +9,7 @@ import unittest
 
 import stem.descriptor
 import stem.version
+import test.require
 
 from stem import Flag
 from stem.util import str_type
@@ -400,6 +401,26 @@ DnN5aFtYKiTc19qIC7Nmo+afPdDEf0MlJvEOP5EWl3w=
       for router in stem.descriptor.parse_file(consensus_file, 'network-status-consensus-3 1.0'):
         self.assertEqual('caerSidi', router.nickname)
 
+  @test.require.cryptography
+  def test_signature_validation(self):
+    """
+    Check that we can validate the consensus with its certificates.
+    """
+
+    with open(get_resource('cached-consensus'), 'rb') as descriptor_file:
+      consensus_content = descriptor_file.read()
+
+    with open(get_resource('cached-certs'), 'rb') as cert_file:
+      certs = list(stem.descriptor.parse_file(cert_file, 'dir-key-certificate-3 1.0'))
+
+    consensus = stem.descriptor.networkstatus.NetworkStatusDocumentV3(consensus_content)
+    consensus.validate_signatures(certs)
+
+    # change a relay's nickname in the consensus so it's no longer validly signed
+
+    consensus = stem.descriptor.networkstatus.NetworkStatusDocumentV3(consensus_content.replace('test002r', 'different_nickname'))
+    self.assertRaisesRegexp(ValueError, 'Network Status Document has 0 valid signatures out of 2 total, needed 1', consensus.validate_signatures, certs)
+
   def test_handlers(self):
     """
     Try parsing a document with DocumentHandler.DOCUMENT and