[tor-commits] [tor-browser-bundle/master] Revert "Bug 21779: Non-admin users can't access Tor Browser on macOS."

[gk at torproject.org]

commit 082738a4bd83943d97e084fa04045e481772b998
Author: Georg Koppen <gk at torproject.org>
Date:   Wed May 24 07:43:18 2017 +0000

    Revert "Bug 21779:  Non-admin users can't access Tor Browser on macOS."
    
    This reverts commit f27d2cab4ed80a4c7b4f594b593b6b90f6148a82.
    
    The problem was the script for recreating the .dmg files after the
    code-signing set the permissions wrong. No need to fix anything in the
    bundle descriptor.
---
 gitian/descriptors/mac/gitian-bundle.yml | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/gitian/descriptors/mac/gitian-bundle.yml b/gitian/descriptors/mac/gitian-bundle.yml
index 54ce237..a2c8408 100644
--- a/gitian/descriptors/mac/gitian-bundle.yml
+++ b/gitian/descriptors/mac/gitian-bundle.yml
@@ -303,11 +303,7 @@ script: |
   rm -f precomplete
   python $MARTOOLS/createprecomplete.py
   popd
-
-  # Ensure that files and directories are accessible by non-admin users
-  # if the app bundle is placed in /Applications. See bug 21779.
-  chmod -R o+rX ~/build/$TORBROWSER_NAME.app
-
+  #
   # Create full MAR file and disk image.
   MAR_FILE=tor-browser-osx${GBUILD_BITS}-${TORBROWSER_VERSION}_${PKG_LOCALE}.mar
   MAR=$MARTOOLS/mar MBSDIFF=$MARTOOLS/mbsdiff $MARTOOLS/make_full_update.sh -q $OUTDIR/$MAR_FILE ~/build/$TORBROWSER_NAME.app
@@ -345,12 +341,7 @@ script: |
       rm -f precomplete
       python $MARTOOLS/createprecomplete.py
       popd
-
-      # Ensure that files and directories are accessible by non-admin users
-      # if the app bundle is placed in /Applications. See bug 21779.
-      chmod -R o+rX ~/build/dmg/$DEST.app
-
-      # Create full MAR file and disk image.
+      #
       MAR_FILE=tor-browser-osx${GBUILD_BITS}-${TORBROWSER_VERSION}_$LANG.mar
       MAR=$MARTOOLS/mar MBSDIFF=$MARTOOLS/mbsdiff $MARTOOLS/make_full_update.sh -q $OUTDIR/$MAR_FILE ~/build/dmg/$DEST.app
       # Rename the Japanese bundle to not confuse users