[tor-commits] [tor-browser-bundle/master] Bug 21779: Non-admin users can't access Tor Browser on macOS.

[gk at torproject.org]

commit f27d2cab4ed80a4c7b4f594b593b6b90f6148a82
Author: Kathy Brade <brade at pearlcrescent.com>
Date:   Wed May 10 15:14:05 2017 -0400

    Bug 21779:  Non-admin users can't access Tor Browser on macOS.
    
    Use chmod to grant permission for "other" to access files within
    TorBrowser.app.
---
 gitian/descriptors/mac/gitian-bundle.yml | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/gitian/descriptors/mac/gitian-bundle.yml b/gitian/descriptors/mac/gitian-bundle.yml
index a2c8408..54ce237 100644
--- a/gitian/descriptors/mac/gitian-bundle.yml
+++ b/gitian/descriptors/mac/gitian-bundle.yml
@@ -303,7 +303,11 @@ script: |
   rm -f precomplete
   python $MARTOOLS/createprecomplete.py
   popd
-  #
+
+  # Ensure that files and directories are accessible by non-admin users
+  # if the app bundle is placed in /Applications. See bug 21779.
+  chmod -R o+rX ~/build/$TORBROWSER_NAME.app
+
   # Create full MAR file and disk image.
   MAR_FILE=tor-browser-osx${GBUILD_BITS}-${TORBROWSER_VERSION}_${PKG_LOCALE}.mar
   MAR=$MARTOOLS/mar MBSDIFF=$MARTOOLS/mbsdiff $MARTOOLS/make_full_update.sh -q $OUTDIR/$MAR_FILE ~/build/$TORBROWSER_NAME.app
@@ -341,7 +345,12 @@ script: |
       rm -f precomplete
       python $MARTOOLS/createprecomplete.py
       popd
-      #
+
+      # Ensure that files and directories are accessible by non-admin users
+      # if the app bundle is placed in /Applications. See bug 21779.
+      chmod -R o+rX ~/build/dmg/$DEST.app
+
+      # Create full MAR file and disk image.
       MAR_FILE=tor-browser-osx${GBUILD_BITS}-${TORBROWSER_VERSION}_$LANG.mar
       MAR=$MARTOOLS/mar MBSDIFF=$MARTOOLS/mbsdiff $MARTOOLS/make_full_update.sh -q $OUTDIR/$MAR_FILE ~/build/dmg/$DEST.app
       # Rename the Japanese bundle to not confuse users