[tor-commits] [tor/master] add an XXX with a minor bug in dirserv_add_multiple_descriptors

[arma at torproject.org]

commit 0266c4ac819d9c835a77a0c1e0334f26f60f6f77
Author: Roger Dingledine <arma at torproject.org>
Date:   Wed May 10 03:11:29 2017 -0400

    add an XXX with a minor bug in dirserv_add_multiple_descriptors
---
 src/or/dirserv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/or/dirserv.c b/src/or/dirserv.c
index 7de72df..c25dbf8 100644
--- a/src/or/dirserv.c
+++ b/src/or/dirserv.c
@@ -571,6 +571,8 @@ dirserv_add_multiple_descriptors(const char *desc, uint8_t purpose,
                    !general ? router_purpose_to_string(purpose) : "",
                    !general ? "\n" : "")<0) {
     *msg = "Couldn't format annotations";
+    /* XXX Not cool: we return -1 below, but (was_router_added_t)-1 is
+     * ROUTER_BAD_EI, which isn't what's gone wrong here. :( */
     return -1;
   }