[tor-commits] [tor/maint-0.3.1] Try a little harder to make sure we never call tor_compress_process wrong.

[nickm at torproject.org]

commit b546d8bc2bfa0e20bdd14181a29a91ba31df2f0e
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Jun 26 09:39:59 2017 -0400

    Try a little harder to make sure we never call tor_compress_process wrong.
---
 src/or/buffers.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/or/buffers.c b/src/or/buffers.c
index 3692ed4..12a6c02 100644
--- a/src/or/buffers.c
+++ b/src/or/buffers.c
@@ -2092,7 +2092,7 @@ fetch_from_buf_line(buf_t *buf, char *data_out, size_t *data_len)
 int
 write_to_buf_compress(buf_t *buf, tor_compress_state_t *state,
                       const char *data, size_t data_len,
-                      int done)
+                      const int done)
 {
   char *next;
   size_t old_avail, avail;
@@ -2114,8 +2114,10 @@ write_to_buf_compress(buf_t *buf, tor_compress_state_t *state,
       case TOR_COMPRESS_ERROR:
         return -1;
       case TOR_COMPRESS_OK:
-        if (data_len == 0)
+        if (data_len == 0) {
+          tor_assert_nonfatal(!done);
           over = 1;
+        }
         break;
       case TOR_COMPRESS_BUFFER_FULL:
         if (avail) {
@@ -2124,6 +2126,11 @@ write_to_buf_compress(buf_t *buf, tor_compress_state_t *state,
            * whether were going to or not. */
           need_new_chunk = 1;
         }
+        if (data_len == 0 && !done) {
+          /* We've consumed all the input data, though, so there's no
+           * point in forging ahead right now. */
+          over = 1;
+        }
         break;
     }
     buf->datalen += old_avail - avail;