[tor-commits] [tor/master] Refrain from needless SOCKS5 warning

nickm at torproject.org nickm at torproject.org
Thu Jun 22 12:17:00 UTC 2017


commit 9e2f78092395d1250f08a21815ab1145409530eb
Author: rl1987 <rl1987 at sdf.lonestar.org>
Date:   Sat Jun 3 18:04:47 2017 +0200

    Refrain from needless SOCKS5 warning
---
 changes/bug22461 | 4 ++++
 src/or/buffers.c | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/changes/bug22461 b/changes/bug22461
new file mode 100644
index 0000000..2fb6a02
--- /dev/null
+++ b/changes/bug22461
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Refrain from needlessly warning Tor controller about passing
+      IP addresses as FQDNs through SOCKS5 interface. Fixes bug
+      22461, bugfix on Tor 0.2.6.2-alpha.
diff --git a/src/or/buffers.c b/src/or/buffers.c
index 3692ed4..1df4be1 100644
--- a/src/or/buffers.c
+++ b/src/or/buffers.c
@@ -1686,8 +1686,6 @@ parse_socks(const char *data, size_t datalen, socks_request_t *req,
 
           if (string_is_valid_ipv4_address(req->address) ||
               string_is_valid_ipv6_address(req->address)) {
-            log_unsafe_socks_warning(5,req->address,req->port,safe_socks);
-
             if (safe_socks) {
               socks_request_set_socks5_error(req, SOCKS5_NOT_ALLOWED);
               return -1;





More information about the tor-commits mailing list