[tor-commits] [goptlib/master] Use bugs.torproject.org permalinks for tickets.

dcf at torproject.org dcf at torproject.org
Tue Jun 20 15:19:41 UTC 2017


commit 8c3894e6f2aef5d72b3388bafdac718c547ea36f
Author: David Fifield <david at bamsoftware.com>
Date:   Tue Jun 20 07:58:15 2017 -0700

    Use bugs.torproject.org permalinks for tickets.
---
 pt.go      | 6 ++++--
 pt_test.go | 4 ++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/pt.go b/pt.go
index f3458ec..ae78f3d 100644
--- a/pt.go
+++ b/pt.go
@@ -449,7 +449,7 @@ type ClientInfo struct {
 // was a list of transport names to use in case Tor requested "*". That feature
 // was never implemented and has been removed from the pluggable transports
 // specification.
-// https://trac.torproject.org/projects/tor/ticket/15612
+// https://bugs.torproject.org/15612
 func ClientSetup(_ []string) (info ClientInfo, err error) {
 	ver, err := getManagedTransportVer()
 	if err != nil {
@@ -494,6 +494,7 @@ func resolveAddr(addrStr string) (*net.TCPAddr, error) {
 		// Before the fixing of bug #7011, tor doesn't put brackets around IPv6
 		// addresses. Split after the last colon, assuming it is a port
 		// separator, and try adding the brackets.
+		// https://bugs.torproject.org/7011
 		parts := strings.Split(addrStr, ":")
 		if len(parts) <= 2 {
 			return nil, err
@@ -654,7 +655,7 @@ type ServerInfo struct {
 // was a list of transport names to use in case Tor requested "*". That feature
 // was never implemented and has been removed from the pluggable transports
 // specification.
-// https://trac.torproject.org/projects/tor/ticket/15612
+// https://bugs.torproject.org/15612
 func ServerSetup(_ []string) (info ServerInfo, err error) {
 	ver, err := getManagedTransportVer()
 	if err != nil {
@@ -773,6 +774,7 @@ func extOrPortAuthenticate(s io.ReadWriter, info *ServerInfo) error {
 	// Work around tor bug #15240 where the auth cookie is generated after
 	// pluggable transports are launched, leading to a stale cookie getting
 	// cached forever if it is only read once as part of ServerSetup.
+	// https://bugs.torproject.org/15240
 	authCookie, err := readAuthCookieFile(info.AuthCookiePath)
 	if err != nil {
 		return fmt.Errorf("error reading TOR_PT_AUTH_COOKIE_FILE %q: %s", info.AuthCookiePath, err.Error())
diff --git a/pt_test.go b/pt_test.go
index f6b9ea8..069647c 100644
--- a/pt_test.go
+++ b/pt_test.go
@@ -181,7 +181,7 @@ func TestGetClientTransports(t *testing.T) {
 		},
 		// In the past, "*" meant to return all known transport names.
 		// But now it has no special meaning.
-		// https://trac.torproject.org/projects/tor/ticket/15612
+		// https://bugs.torproject.org/15612
 		{
 			"*",
 			[]string{"*"},
@@ -381,7 +381,7 @@ func TestGetServerBindaddrs(t *testing.T) {
 		},
 		// In the past, "*" meant to return all known transport names.
 		// But now it has no special meaning.
-		// https://trac.torproject.org/projects/tor/ticket/15612
+		// https://bugs.torproject.org/15612
 		{
 			"alpha-1.2.3.4:1111,beta-[1:2::3:4]:2222",
 			"*",





More information about the tor-commits mailing list