[tor-commits] [stem/master] Disable sockstat integ test

atagar at torproject.org atagar at torproject.org
Fri Jul 28 15:55:28 UTC 2017


commit d0d127ba5fb9b76cad3e7393c00bf3d4d2ae35be
Author: Damian Johnson <atagar at torproject.org>
Date:   Fri Jul 28 08:56:36 2017 -0700

    Disable sockstat integ test
    
    Test is failing on our Jenkins hosts and I'm pretty stumped about why. We'll
    drop sockstat in 2.0.0 unless fixed...
    
      https://trac.torproject.org/projects/tor/ticket/23057
---
 stem/util/connection.py       | 4 ++++
 test/integ/util/connection.py | 3 ---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/stem/util/connection.py b/stem/util/connection.py
index 91608538..464a9ca1 100644
--- a/stem/util/connection.py
+++ b/stem/util/connection.py
@@ -35,6 +35,10 @@ Connection and networking based utility functions.
   .. versionchanged:: 1.6.0
      Added **BSD_FSTAT**.
 
+  .. deprecated:: 1.6.0
+     The SOCKSTAT connection resolver is proving to be unreliable
+     (:trac:`23057`), and will be dropped in the 2.0.0 release unless fixed.
+
   ====================  ===========
   Resolver              Description
   ====================  ===========
diff --git a/test/integ/util/connection.py b/test/integ/util/connection.py
index bda9a414..19ba1996 100644
--- a/test/integ/util/connection.py
+++ b/test/integ/util/connection.py
@@ -51,9 +51,6 @@ class TestConnection(unittest.TestCase):
   def test_connections_by_lsof(self):
     self.check_resolver(Resolver.LSOF)
 
-  def test_connections_by_sockstat(self):
-    self.check_resolver(Resolver.SOCKSTAT)
-
   def test_connections_by_bsd_sockstat(self):
     self.check_resolver(Resolver.BSD_SOCKSTAT)
 



More information about the tor-commits mailing list