[tor-commits] [sandboxed-tor-browser/master] fixup! Bug 22853: Something in Ubuntu's libraries is totally brain damaged.

[yawning at torproject.org]

commit 0bc11b69682026c3c01ef0a36e5cbf4babd17798
Author: Yawning Angel <yawning at schwanenlied.me>
Date:   Fri Jul 7 18:41:59 2017 +0000

    fixup! Bug 22853: Something in Ubuntu's libraries is totally brain damaged.
    
    This actually is a SelfRando bug.
---
 ChangeLog                                                     | 2 +-
 src/cmd/sandboxed-tor-browser/internal/sandbox/application.go | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 3c95c7c..d9679bb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,6 @@
 Changes in version 0.0.10 - UNRELEASED:
  * Bug 22829: Remove default obfs4 bridge riemann.
- * Bug 22853: Something in Ubuntu's libraries is totally brain damaged.
+ * Bug 22853: Something in SelfRando is totally brain damaged.
 
 Changes in version 0.0.9 - 2017-07-03:
  * Bug 22712: Suppress ATK Bridge initialization which will never work.
diff --git a/src/cmd/sandboxed-tor-browser/internal/sandbox/application.go b/src/cmd/sandboxed-tor-browser/internal/sandbox/application.go
index 5bc9ace..659c835 100644
--- a/src/cmd/sandboxed-tor-browser/internal/sandbox/application.go
+++ b/src/cmd/sandboxed-tor-browser/internal/sandbox/application.go
@@ -71,10 +71,8 @@ func RunTorBrowser(cfg *config.Config, manif *config.Manifest, tor *tor.Tor) (pr
 	h.fakeDbus = true
 	h.mountProc = false
 
-	// Dear Ubuntu.  While I realize that this may be a hard concept to grasp,
-	// if `openat()` returns -1 (ENOENT), the correct thing to do is NOT spin
-	// endlessly calling `read()` in a tight loop (ignoring the -1/EBADFD)
-	// status.
+	// Work around the SelfRando developers not knowing how the x86_64 Linux
+	// system call calling convention works.
 	h.file("/proc/self/environ", []byte{})
 
 	// Gtk+ and PulseAudio.