[tor-commits] [tor/master] entrynodes: Remove "split these functions" XXXXs

nickm at torproject.org nickm at torproject.org
Mon Jan 30 16:57:44 UTC 2017


commit cccd3f1dae32075ffd4c53de7709fc83b7db43fb
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Jan 30 10:49:40 2017 -0500

    entrynodes: Remove "split these functions" XXXXs
    
    They now have a ticket: #21349.
---
 src/or/entrynodes.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c
index 587dec6..c5fb92e 100644
--- a/src/or/entrynodes.c
+++ b/src/or/entrynodes.c
@@ -1157,7 +1157,6 @@ entry_guard_is_listed,(guard_selection_t *gs, const entry_guard_t *guard))
 STATIC void
 sampled_guards_update_from_consensus(guard_selection_t *gs)
 {
-  /*XXXX prop271 consider splitting this function up. */
   tor_assert(gs);
   const int REMOVE_UNLISTED_GUARDS_AFTER =
     (get_remove_unlisted_guards_after_days() * 86400);
@@ -1581,7 +1580,6 @@ make_guard_confirmed(guard_selection_t *gs, entry_guard_t *guard)
 STATIC void
 entry_guards_update_primary(guard_selection_t *gs)
 {
-  /*XXXX prop271 consider splitting this function up. */
   tor_assert(gs);
 
   // prevent recursion. Recursion is potentially very bad here.
@@ -1779,7 +1777,6 @@ select_entry_guard_for_circuit(guard_selection_t *gs,
                                const entry_guard_restriction_t *rst,
                                unsigned *state_out)
 {
-  /*XXXX prop271 consider splitting this function up. */
   tor_assert(gs);
   tor_assert(state_out);
 



More information about the tor-commits mailing list