[tor-commits] [tor/master] Remove XXXXprop271 comments from test_entrynodes.c

nickm at torproject.org nickm at torproject.org
Mon Jan 30 16:57:44 UTC 2017


commit ed4a3dfef20935e6f357c2881a2db6b2b4445566
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Jan 30 10:43:53 2017 -0500

    Remove XXXXprop271 comments from test_entrynodes.c
    
    These commments were complaints about how I didn't like some aspects
    of prop271.  They have been superseded by ticket 20832.
---
 src/test/test_entrynodes.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/test/test_entrynodes.c b/src/test/test_entrynodes.c
index bcb56e3..249fd1f 100644
--- a/src/test/test_entrynodes.c
+++ b/src/test/test_entrynodes.c
@@ -2044,7 +2044,6 @@ test_entry_guard_select_for_circuit_highlevel_confirm_other(void *arg)
   u = entry_guard_succeeded(&guard);
   /* We're on the internet (by fiat), so this guard will get called "confirmed"
    * and should immediately become primary.
-   * XXXX prop271 -- I don't like that behavior, but it's what is specified
    */
   tt_int_op(guard->state, OP_EQ, GUARD_CIRC_STATE_COMPLETE);
   tt_assert(u == GUARD_USABLE_NOW);
@@ -2338,9 +2337,6 @@ test_entry_guard_upgrade_a_circuit(void *arg)
    * primary guards are down, we have two WAITING circuits: one will
    * get upgraded to COMPLETED!  (The one that started first.)
    */
-  /*     XXXX prop271 -- perhaps the one that started first should
-   *      also wind up in confirmed_entry_guards earlier?
-   */
 
   smartlist_t *result = smartlist_new();
   int r;





More information about the tor-commits mailing list