[tor-commits] [tor/master] Fix a double-free in rend_config_services()

nickm at torproject.org nickm at torproject.org
Tue Jan 17 16:36:08 UTC 2017


commit 92c3926479de1511dc4607fdc1f9b8fa0fa9f47b
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Jan 17 11:35:26 2017 -0500

    Fix a double-free in rend_config_services()
    
    Found by coverity scan; CID 1398917
---
 src/or/rendservice.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/or/rendservice.c b/src/or/rendservice.c
index bf34aee..e423cb7 100644
--- a/src/or/rendservice.c
+++ b/src/or/rendservice.c
@@ -691,7 +691,6 @@ rend_config_services(const or_options_t *options, int validate_only)
         log_warn(LD_CONFIG,
                  "HiddenServiceAllowUnknownPorts should be 0 or 1, not %s",
                  line->value);
-        smartlist_free(temp_service_list);
         goto free_and_return;
       }
       log_info(LD_CONFIG,



More information about the tor-commits mailing list