[tor-commits] [tor/master] The UseCreateFast consensus parameter now defaults to 0.

[nickm at torproject.org]

commit d004b9222e6f07f01666aa2de852fc19e9096a08
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Feb 16 15:30:26 2017 -0500

    The UseCreateFast consensus parameter now defaults to 0.
    
    You can still override it with FastFirstHopPK.  But that's
    deprecated.
    
    Closes ticket 21407.
---
 changes/bug21407      | 4 ++++
 src/or/circuitbuild.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/changes/bug21407 b/changes/bug21407
new file mode 100644
index 0000000..8d0d917
--- /dev/null
+++ b/changes/bug21407
@@ -0,0 +1,4 @@
+  o Minor features (defaults, security):
+    - The default value for UseCreateFast is now 0: clients which haven't yet
+      received a consensus document will nonetheless use a proper handshake
+      to talk to their directory servers (when they can). Closes ticket 21407.
diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c
index cd00034..d688172 100644
--- a/src/or/circuitbuild.c
+++ b/src/or/circuitbuild.c
@@ -819,7 +819,7 @@ should_use_create_fast_for_circuit(origin_circuit_t *circ)
   }
   if (options->FastFirstHopPK == -1) {
     /* option is "auto", so look at the consensus. */
-    return networkstatus_get_param(NULL, "usecreatefast", 1, 0, 1);
+    return networkstatus_get_param(NULL, "usecreatefast", 0, 0, 1);
   }
 
   return options->FastFirstHopPK;