[tor-commits] [tor/master] give tor_version_parse_platform some function documentation

nickm at torproject.org nickm at torproject.org
Wed Feb 15 12:51:16 UTC 2017


commit 3c4da8a130e41b9096eef360c437cef3cd22a62c
Author: Roger Dingledine <arma at torproject.org>
Date:   Tue Feb 14 03:52:01 2017 -0500

    give tor_version_parse_platform some function documentation
---
 src/or/routerparse.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/or/routerparse.c b/src/or/routerparse.c
index 28b9c57..c4691b5 100644
--- a/src/or/routerparse.c
+++ b/src/or/routerparse.c
@@ -5512,9 +5512,14 @@ microdescs_parse_from_string(const char *s, const char *eos,
   return result;
 }
 
-/** Parse the Tor version of the platform string <b>platform</b>,
- * and compare it to the version in <b>cutoff</b>. Return 1 if
- * the router is at least as new as the cutoff, else return 0.
+/** Extract a Tor version from a <b>platform</b> line from a router
+ * descriptor, and place the result in <b>router_version</b>.
+ *
+ * Return 1 on success, -1 on parsing failure, and 0 if the
+ * platform line does not indicate some version of Tor.
+ *
+ * If <b>strict</b> is non-zero, finding any weird version components
+ * (like negative numbers) counts as a parsing failure.
  */
 int
 tor_version_parse_platform(const char *platform,
@@ -5552,6 +5557,7 @@ tor_version_parse_platform(const char *platform,
       return -1;
     }
   }
+
   return 1;
 }
 





More information about the tor-commits mailing list