[tor-commits] [tor/master] Improve add_msec test to cover ms->sec rollover

nickm at torproject.org nickm at torproject.org
Wed Dec 20 14:18:28 UTC 2017


commit 60bf8f6cf6295808eec542be31649b0bd82ad926
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Dec 20 09:12:38 2017 -0500

    Improve add_msec test to cover ms->sec rollover
    
    Per mikeperry's suggestion, I'm making sure that the millisecond
    part of the time will always roll over in this test.
---
 src/test/test_util.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/test/test_util.c b/src/test/test_util.c
index 1c58ad695..9d139917f 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -5970,6 +5970,16 @@ test_util_monotonic_time_add_msec(void *arg)
   tt_i64_op(monotime_diff_msec(&t1, &t2), OP_EQ, 1337);
   tt_i64_op(monotime_coarse_diff_msec(&ct1, &ct2), OP_EQ, 1337);
 
+  /* Add 1337 msec twice more; make sure that any second rollover issues
+   * worked. */
+  monotime_add_msec(&t2, &t2, 1337);
+  monotime_coarse_add_msec(&ct2, &ct2, 1337);
+  monotime_add_msec(&t2, &t2, 1337);
+  monotime_coarse_add_msec(&ct2, &ct2, 1337);
+  tt_i64_op(monotime_diff_msec(&t1, &t2), OP_EQ, 1337*3);
+  tt_i64_op(monotime_coarse_diff_msec(&ct1, &ct2), OP_EQ, 1337*3);
+
+  
  done:
   ;
 }





More information about the tor-commits mailing list