[tor-commits] [tor/master] chan: Add changes file for ticket 23709

nickm at torproject.org nickm at torproject.org
Fri Dec 8 19:46:20 UTC 2017


commit 50124fd7a643deaa9a4072b2e54278226baaf5b0
Author: David Goulet <dgoulet at torproject.org>
Date:   Fri Dec 8 11:40:16 2017 -0500

    chan: Add changes file for ticket 23709
    
    Closes #23709
    
    Signed-off-by: David Goulet <dgoulet at torproject.org>
---
 changes/ticket23709 | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/changes/ticket23709 b/changes/ticket23709
new file mode 100644
index 000000000..7948f9ae0
--- /dev/null
+++ b/changes/ticket23709
@@ -0,0 +1,11 @@
+  o Major feature (channel):
+    - Remove the incoming and outgoing channel queues. The reason to do so was
+      due to the fact that they were always empty meaning never used but still
+      looked at in our fast path. Bottom line, it was an unused code path.
+    - We've simplify a lot the channel subsystem by removing those queues but
+      also by removing a lot of unused code or dead code around it. Overall
+      this is a cleanup removing more than 1500 lines of code overall and
+      adding very little except for unit test.
+    - The majority ot the channel unit tests have been rewritten and the code
+      coverage has now been raised to 83.6% for channel.c.
+      Closes ticket 23709.





More information about the tor-commits mailing list