[tor-commits] [tor/master] hs-v3: Downgrade warning log when an intro circuit has closed

nickm at torproject.org nickm at torproject.org
Wed Dec 6 00:44:53 UTC 2017


commit 4633a93ca841c36e9c36ae31bc6745c47f85767e
Author: David Goulet <dgoulet at torproject.org>
Date:   Thu Nov 9 14:30:20 2017 -0500

    hs-v3: Downgrade warning log when an intro circuit has closed
    
    When an intro circuit has closed, do not warn anymore when we can't find the
    service. It is possible to hit that condition if the service is removed before
    the circuits were fully closed. This happens in the case of deleting an
    ephemeral service.
    
    Signed-off-by: David Goulet <dgoulet at torproject.org>
---
 src/or/hs_service.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/or/hs_service.c b/src/or/hs_service.c
index 944400a0e..a659a126f 100644
--- a/src/or/hs_service.c
+++ b/src/or/hs_service.c
@@ -3079,7 +3079,9 @@ hs_service_intro_circ_has_closed(origin_circuit_t *circ)
 
   get_objects_from_ident(circ->hs_ident, &service, &ip, &desc);
   if (service == NULL) {
-    log_warn(LD_REND, "Unable to find any hidden service associated "
+    /* This is possible if the circuits are closed and the service is
+     * immediately deleted. */
+    log_info(LD_REND, "Unable to find any hidden service associated "
                       "identity key %s on intro circuit %u.",
              ed25519_fmt(&circ->hs_ident->identity_pk),
              TO_CIRCUIT(circ)->n_circ_id);





More information about the tor-commits mailing list