[tor-commits] [torspec/master] 15333: Correct replies for GETINFO, SETCONF

[nickm at torproject.org]

commit d92fc8b17b207cfb8131f6922a95d022c37c06c8
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Aug 23 09:36:33 2017 -0400

    15333: Correct replies for GETINFO, SETCONF
    
    SETCONF says 250 ok on success, like everything else.
    
    GETINFO had some junk left around in it that was left over from good
    old control-spec-v0.txt.
---
 control-spec.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/control-spec.txt b/control-spec.txt
index 12a559f..b31111c 100644
--- a/control-spec.txt
+++ b/control-spec.txt
@@ -267,7 +267,7 @@
   to set it back to its default).  SETCONF is all-or-nothing: if there
   is an error in any of the configuration settings, Tor sets none of them.
 
-  Tor responds with a "250 configuration values set" reply on success.
+  Tor responds with a "250 OK" reply on success.
   If some of the listed keywords can't be found, Tor replies with a
   "552 Unrecognized option" message. Otherwise, Tor responds with a
   "513 syntax error in configuration values" reply on syntax error, or a
@@ -495,8 +495,6 @@
 
   Sent from the client to the server.  The syntax is as for GETCONF:
     "GETINFO" 1*(SP keyword) CRLF
-  one or more NL-terminated strings.  The server replies with an INFOVALUE
-  message, or a 551 or 552 error.
 
   Unlike GETCONF, this message is used for data that are not stored in the Tor
   configuration file, and that may be longer than a single line.  On success,
@@ -507,6 +505,8 @@
       250+keyword=
       value
       .
+  The server sends a 551 or 552 error on failure.
+
   Recognized keys and their values include:
 
     "version" -- The version of the server's software, which MAY include the