[tor-commits] [tor/master] Put comment in the trunnel file, so it wont go away.

nickm at torproject.org nickm at torproject.org
Wed Aug 9 00:36:39 UTC 2017

commit 2f17743d6f7222cf96250890dd91d6689b2d55c6
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Aug 8 20:31:47 2017 -0400

    Put comment in the trunnel file, so it wont go away.
 src/trunnel/ed25519_cert.trunnel | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/trunnel/ed25519_cert.trunnel b/src/trunnel/ed25519_cert.trunnel
index e424ce546..8d6483d55 100644
--- a/src/trunnel/ed25519_cert.trunnel
+++ b/src/trunnel/ed25519_cert.trunnel
@@ -28,6 +28,12 @@ const LS_IPV6 = 0x01;
 const LS_LEGACY_ID = 0x02;
 const LS_ED25519_ID = 0x03;
+// XXX hs_link_specifier_dup() violates the opaqueness of link_specifier_t by
+//  taking its sizeof(). If we ever want to turn on TRUNNEL_OPAQUE, or
+//  if we ever make link_specifier contain other types, we will
+//  need to refactor that function to do the copy by encoding and decoding the
+//  object.
 // amended from tor.trunnel
 struct link_specifier {
   u8 ls_type;

More information about the tor-commits mailing list