[tor-commits] [tor/master] prop224 tests: Don't use tt_size_op to compare ssize_t.

nickm at torproject.org nickm at torproject.org
Wed Apr 19 01:42:26 UTC 2017


commit a3ce303432f35a6f06f63f0679b9bb577f88dc3c
Author: George Kadianakis <desnacked at riseup.net>
Date:   Mon Apr 17 16:23:58 2017 +0300

    prop224 tests: Don't use tt_size_op to compare ssize_t.
    
    Addresses coverity CID 1405129.
---
 src/test/test_hs_intropoint.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/test/test_hs_intropoint.c b/src/test/test_hs_intropoint.c
index 7bcd568..ef5cb46 100644
--- a/src/test/test_hs_intropoint.c
+++ b/src/test/test_hs_intropoint.c
@@ -777,11 +777,11 @@ test_received_introduce1_handling(void *arg)
   {
     cell = helper_create_introduce1_cell();
     ssize_t request_len = trn_cell_introduce1_encoded_len(cell);
-    tt_size_op(request_len, OP_GT, 0);
+    tt_int_op((int)request_len, OP_GT, 0);
     request = tor_malloc_zero(request_len);
     ssize_t encoded_len =
       trn_cell_introduce1_encode(request, request_len, cell);
-    tt_size_op(encoded_len, OP_GT, 0);
+    tt_int_op((int)encoded_len, OP_GT, 0);
 
     circ = helper_create_intro_circuit();
     or_circuit_t *service_circ = helper_create_intro_circuit();
@@ -812,7 +812,7 @@ test_received_introduce1_handling(void *arg)
     request = tor_malloc_zero(request_len + 256);
     ssize_t encoded_len =
       trn_cell_introduce1_encode(request, request_len, cell);
-    tt_size_op(encoded_len, OP_GT, 0);
+    tt_int_op((int)encoded_len, OP_GT, 0);
 
     circ = helper_create_intro_circuit();
     or_circuit_t *service_circ = helper_create_intro_circuit();





More information about the tor-commits mailing list