[tor-commits] [tor/master] Ensure that dir1 and dir2 are freed at the end of poisoning test

nickm at torproject.org nickm at torproject.org
Wed Sep 14 15:02:06 UTC 2016


commit b08ddb60c9a2bfb133889a399d4e6d01af5a59d9
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Sep 14 11:01:21 2016 -0400

    Ensure that dir1 and dir2 are freed at the end of poisoning test
    
    Found by coverity.
---
 src/test/test_hs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/test/test_hs.c b/src/test/test_hs.c
index a9cd315..fd5ab15 100644
--- a/src/test/test_hs.c
+++ b/src/test/test_hs.c
@@ -568,6 +568,7 @@ test_single_onion_poisoning(void *arg)
 
   service_1->directory = dir1;
   service_2->directory = dir2;
+  dir1 = dir2 = NULL;
   smartlist_add(services, service_1);
   /* But don't add the second service yet. */
 
@@ -699,6 +700,8 @@ test_single_onion_poisoning(void *arg)
   smartlist_free(services);
   UNMOCK(get_options);
   tor_free(mock_options->DataDirectory);
+  tor_free(dir1);
+  tor_free(dir2);
 }
 
 struct testcase_t hs_tests[] = {



More information about the tor-commits mailing list