[tor-commits] [tor-browser-spec/master] Bug 19920: Update audit notes with iSEC suggestions

gk at torproject.org gk at torproject.org
Fri Sep 2 18:12:07 UTC 2016


commit 82f9fc99651afc6450f300d1ca78c8ff4af28a0d
Author: Georg Koppen <gk at torproject.org>
Date:   Mon Aug 15 14:16:47 2016 +0000

    Bug 19920: Update audit notes with iSEC suggestions
    
    iSEC suggested to diff the preference files of a vanilla Firefox ESR and
    the Tor Browser one to catch issues that might have fallen through the
    cracks during the feature review.
---
 audits/GENERAL | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/audits/GENERAL b/audits/GENERAL
index f72fd38..12dc590 100644
--- a/audits/GENERAL
+++ b/audits/GENERAL
@@ -31,4 +31,9 @@ When we finally start preparations for the switch to ESR 45 we basically have
 all the ff45-esr tickets filed, and ideally prioritized, which are resulting
 out of Firefox 39-44 reviews. The only remaining tasks for the feature review
 are: taking care of ESR 45 and double-checking the undocumented bugs and the
-ones with milestone Firefox39-45.
+ones with milestone Firefox39-45. Additionally, it is worth comparing the
+preference changes by diffing `all.js` and `firefox.js` to make sure all
+features we want to be disabled are still disabled and things we want to have
+enabled are so in fact. Checking the diff between those preference files might
+as well help finding issues we overlooked while doing the feature review
+outlined above.



More information about the tor-commits mailing list