[tor-commits] [metrics-web/master] Make another minor tweak to the #20049 fix.

[karsten at torproject.org]

commit 62ad25feaf8a0514cee7e82e35d60c1577d6f69f
Author: Karsten Loesing <karsten.loesing at gmx.net>
Date:   Thu Sep 1 21:14:06 2016 +0200

    Make another minor tweak to the #20049 fix.
---
 .../torproject/ernie/cron/network/ConsensusStatsFileHandler.java  | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/modules/legacy/src/org/torproject/ernie/cron/network/ConsensusStatsFileHandler.java b/modules/legacy/src/org/torproject/ernie/cron/network/ConsensusStatsFileHandler.java
index 824e1eb..3e71348 100644
--- a/modules/legacy/src/org/torproject/ernie/cron/network/ConsensusStatsFileHandler.java
+++ b/modules/legacy/src/org/torproject/ernie/cron/network/ConsensusStatsFileHandler.java
@@ -139,6 +139,8 @@ public class ConsensusStatsFileHandler {
                 + "! Aborting to read this file!");
             break;
           }
+          /* Assume that all lines without authority nickname are based on
+           * Tonga's network status, not Bifroest's. */
           String key = parts[0] + "," + (parts.length < 4 ? "Tonga" : parts[1]);
           String value = null;
           if (parts.length == 2) {
@@ -147,11 +149,7 @@ public class ConsensusStatsFileHandler {
             value = key + "," + parts[1] + "," + parts[2];
           } else if (parts.length == 4) {
             value = key + "," + parts[2] + "," + parts[3];
-          } else {
-            /* Impossible, we already checked the range above. */
-          }
-          /* Assume that all lines without authority nickname are based on
-           * Tonga's network status, not Bifroest's. */
+          } /* No more cases as we already checked the range above. */
           this.bridgesRaw.put(key, value);
         }
         br.close();