[tor-commits] [tor/master] Add implementation of smartlist_add_strdup

[nickm at torproject.org]

commit b8b8b6b70e670cb735b43bc6b90150ab1ed4e2d1
Author: overcaffeinated <overcaffeinated at airmail.cc>
Date:   Thu Oct 27 10:12:28 2016 +0100

    Add implementation of smartlist_add_strdup
    
    Add smartlist_add_strdup(sl, string) - replaces the use of
    smartlist_add(sl, tor_strdup(string)). Fixes bug 20048.
---
 changes/bug20048  |  4 ++++
 src/common/util.c | 11 +++++++++++
 src/common/util.h |  1 +
 3 files changed, 16 insertions(+)

diff --git a/changes/bug20048 b/changes/bug20048
new file mode 100644
index 0000000..0874e97
--- /dev/null
+++ b/changes/bug20048
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Implement smartlist_add_strdup() function. Replaces the use of
+      smartlist_add(sl, tor_strdup(str)). Fixes bug 20048. 
+
diff --git a/src/common/util.c b/src/common/util.c
index 9162967..02ccf4f 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -3532,6 +3532,17 @@ smartlist_add_vasprintf(struct smartlist_t *sl, const char *pattern,
   smartlist_add(sl, str);
 }
 
+/** Append a copy of string to sl */
+void
+smartlist_add_strdup(struct smartlist_t *sl, const char *string)
+{
+  char *copy;
+
+  copy = tor_strdup(string);
+
+  smartlist_add(sl, copy);
+}
+
 /** Return a new list containing the filenames in the directory <b>dirname</b>.
  * Return NULL on error or if <b>dirname</b> is not a directory.
  */
diff --git a/src/common/util.h b/src/common/util.h
index 479fc8d..37f4bed 100644
--- a/src/common/util.h
+++ b/src/common/util.h
@@ -239,6 +239,7 @@ void smartlist_add_asprintf(struct smartlist_t *sl, const char *pattern, ...)
 void smartlist_add_vasprintf(struct smartlist_t *sl, const char *pattern,
                              va_list args)
   CHECK_PRINTF(2, 0);
+void smartlist_add_strdup(struct smartlist_t *sl, const char *string);
 
 /* Time helpers */
 long tv_udiff(const struct timeval *start, const struct timeval *end);