[tor-commits] [tor/master] Remove redundant group permission code from rend_service_check_private_dir

nickm at torproject.org nickm at torproject.org
Mon Nov 7 21:31:50 UTC 2016


commit 6c541815592b76ecb7dc639123bce894bf47b67f
Author: teor <teor2345 at gmail.com>
Date:   Wed Nov 2 11:20:49 2016 +1100

    Remove redundant group permission code from rend_service_check_private_dir
    
    check_private_dir already does this for existing directories.
---
 src/or/rendservice.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/or/rendservice.c b/src/or/rendservice.c
index 610ed75..dca775e 100644
--- a/src/or/rendservice.c
+++ b/src/or/rendservice.c
@@ -1265,15 +1265,6 @@ rend_service_check_private_dir(const rend_service_t *s, int create)
   if (check_private_dir(s->directory, check_opts, get_options()->User) < 0) {
     return -1;
   }
-#ifndef _WIN32
-  if (s->dir_group_readable && create) {
-    /* Only new dirs created get new opts, also enforce group read. */
-    if (chmod(s->directory, 0750)) {
-      log_warn(LD_FS,"Unable to make %s group-readable.", s->directory);
-    }
-  }
-#endif
-
   return 0;
 }
 





More information about the tor-commits mailing list